Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PST cards in grid #466

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Feb 1, 2024

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Feb 1, 2024
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f221a7d
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/65c29ce219ec89000885d2f5
😎 Deploy Preview https://deploy-preview-466--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Member

stefanv commented Feb 1, 2024

I like the yaml idea, FWIW, otherwise specifying the cards soon becomes unwieldy.

And instead of storing that information in a file, it can appear directly in the shortcode body. See https://gohugo.io/functions/transform/unmarshal/

@jarrodmillman
Copy link
Member Author

This isn't ready, but I am merging so @brianhawthorne can refactor and fix it.

@jarrodmillman jarrodmillman merged commit c980ce7 into scientific-python:main Feb 6, 2024
5 of 6 checks passed
@jarrodmillman jarrodmillman deleted the grids branch February 6, 2024 20:58
@jarrodmillman jarrodmillman added this to the 0.10 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants