Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rem for fonts, margins, and padding #561

Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented Mar 23, 2024

Use rem instead of px for font sizes, margins, and paddings. I left assets/theme-css/navbar.css and assets/theme-css/hero.css alone, since I plan to revisit them soon.

@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Mar 23, 2024
Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f9b7892
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6603fb1af41e180008f11d8a
😎 Deploy Preview https://deploy-preview-561--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman force-pushed the rem4-font-margin-padding branch 3 times, most recently from 5e5a007 to 88e0cf4 Compare March 23, 2024 15:04
@jarrodmillman jarrodmillman marked this pull request as draft March 23, 2024 15:10
@jarrodmillman jarrodmillman force-pushed the rem4-font-margin-padding branch 3 times, most recently from 86aa217 to 472c1d8 Compare March 27, 2024 10:12
@jarrodmillman jarrodmillman marked this pull request as ready for review March 27, 2024 10:12
@jarrodmillman jarrodmillman added type: Maintenance and removed type: Enhancement New feature or request labels Mar 27, 2024
@jarrodmillman jarrodmillman merged commit d567bb1 into scientific-python:main Mar 27, 2024
8 checks passed
@jarrodmillman jarrodmillman deleted the rem4-font-margin-padding branch March 27, 2024 11:21
@jarrodmillman jarrodmillman added this to the 0.16 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants