Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve color handling #594

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman commented May 2, 2024

Will need to fix:

numpy.org/assets/css/mailchimp.css:  border-right: 1px solid var(--colorPrimaryDark);
numpy.org/assets/css/mailchimp.css:  fill: var(--colorPrimaryDark);
numpy.org/assets/css/mailchimp.css:  color: var(--colorPrimaryDark);
numpy.org/assets/css/mailchimp.css:  fill: var(--colorPrimaryDark);
numpy.org/assets/css/mailchimp.css:  background-color: var(--colorSecondary);
numpy.org/assets/css/mailchimp.css:  background-color: var(--colorSecondary);
numpy.org/assets/css/mailchimp.css:  color: var(--colorSecondary);
numpy.org/assets/css/mailchimp.css:  color: var(--colorSecondary);

Copy link

netlify bot commented May 2, 2024

Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0bb8c29
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/6633cdc843eb640008dc5a3f
😎 Deploy Preview https://deploy-preview-594--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82
Accessibility: 100
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jarrodmillman jarrodmillman marked this pull request as draft May 2, 2024 16:11
@stefanv stefanv marked this pull request as ready for review May 2, 2024 22:39
@stefanv stefanv changed the title Improve color handling Improve color handling & move features to user guide May 2, 2024
@stefanv stefanv changed the title Improve color handling & move features to user guide Improve color handling May 2, 2024
@stefanv stefanv merged commit 4543388 into scientific-python:main May 2, 2024
6 checks passed
@jarrodmillman jarrodmillman added this to the 0.18 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants