Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: printing a typetracer array should not touch it #3019

Merged
merged 7 commits into from
Mar 6, 2024
Merged

feat!: printing a typetracer array should not touch it #3019

merged 7 commits into from
Mar 6, 2024

Commits on Feb 12, 2024

  1. first, PlaceholderArray should be printable (as '??') so that not-tou… 

    …ching on the Dask head node doesn't allow for errors on the Dask workers
    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c52a139 View commit details
    Browse the repository at this point in the history

  2. second, we remove the explicit '_touch_data' from _prettyprint.py

    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fec4bda View commit details
    Browse the repository at this point in the history

  3. third, also protect layout repr against both TypeTracers and Placehol… 

    …derArrays
    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b35a4f3 View commit details
    Browse the repository at this point in the history

  4. pre-commit

    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fd73a9f View commit details
    Browse the repository at this point in the history

  5. update tests

    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    14c4d1b View commit details
    Browse the repository at this point in the history

  6. no quotation marks around the '??' in output

    @jpivarski
    jpivarski committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    057fbf2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' into jpivarski/printing-a-typetracer-array-should… 

    …-not-touch-it
    @jpivarski
    jpivarski committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    fa8ba47 View commit details
    Browse the repository at this point in the history