Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add miscellaneous CUDA kernels #3021

Merged
merged 24 commits into from
Mar 21, 2024
Merged

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Feb 12, 2024

Added following CUDA kernels:

  • awkward_IndexedArray_flatten_none2empty
  • awkward_ListArray_combinations_length
  • awkward_ListOffsetArray_local_preparenext
  • awkward_sorting_ranges
  • awkward_ListArray_rpad_axis1 (variable-length inner loop)
  • awkward_ListOffsetArray_rpad_axis1
  • awkward_NumpyArray_pad_zero_to_length

@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Feb 26, 2024
@ManasviGoyal
Copy link
Collaborator Author

@jpivarski Packaging tests for ubuntu seem to be failing for all PRs

@jpivarski
Copy link
Member

It's not finding numpy.AxisError, and it looks like it's installing numpy-1.26.4, not NumPy 2.0 or anything. That's very strange. Maybe it's installing a different NumPy at a later stage in the workflow? (I didn't follow it through to the end.)

@ManasviGoyal
Copy link
Collaborator Author

It's not finding numpy.AxisError, and it looks like it's installing numpy-1.26.4, not NumPy 2.0 or anything. That's very strange. Maybe it's installing a different NumPy at a later stage in the workflow? (I didn't follow it through to the end.)

I do see NumPy 2.0 before the error

Successfully installed awkward-cpp-30 numpy-2.0.0b1

@jpivarski
Copy link
Member

Then #2936 has arrived, @tcawlfield!

@ManasviGoyal ManasviGoyal marked this pull request as ready for review March 21, 2024 14:41
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I thought I had reviewed and merged this earlier, but apparently hadn't. I had no comments or changes then, so I'll merge it now.

@jpivarski jpivarski merged commit 7a4ec81 into main Mar 21, 2024
38 checks passed
@jpivarski jpivarski deleted the ManasviGoyal/add-misc-kernels branch March 21, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants