Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: TEMPORARY edits to get tests working for all PRs: NumPy 2.0 cap and turned off Try-It #3057

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

jpivarski
Copy link
Member

This must not propagate into any non-RC releases of Awkward because upper caps on version dependencies are bad for libraries. But, for the sake of merging PRs into main, we want to see that they pass all tests without NumPy 2.0, at least.

Note for @tcawlfield: when successful, I'll be merging this PR into main and from there into all of the open PRs. Naturally, it should not go into your PR that is fixing #2936. (Your PR can just remove these ,<2.0 constraints, and when it works, it will merge into main and everyone else will get the benefits at that time.)

@jpivarski
Copy link
Member Author

It got past the issue with package-building, which is what all the other PRs need, but—oddly enough—fails in JupyterLite:

TaskError - taskid:post_build:jupyterlite-pyodide-kernel-piplite:patch
PythonAction Error
Traceback (most recent call last):
  File "/home/runner/micromamba/envs/awkward-docs/lib/python3.11/site-packages/doit/action.py", line 461, in execute
    returned_value = self.py_callable(*self.args, **kwargs)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/awkward-docs/lib/python3.11/site-packages/jupyterlite_pyodide_kernel/addons/piplite.py", line 245, in patch_jupyterlite_json
    write_wheel_index(self.output_wheels, metadata)
  File "/home/runner/micromamba/envs/awkward-docs/lib/python3.11/site-packages/jupyterlite_pyodide_kernel/addons/piplite.py", line 363, in write_wheel_index
    index_data = get_wheel_index(list_wheels(whl_dir), metadata)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/awkward-docs/lib/python3.11/site-packages/jupyterlite_pyodide_kernel/addons/piplite.py", line 352, in get_wheel_index
    normalized_name = re.sub(r"[-_.]+", "-", name).lower()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/micromamba/envs/awkward-docs/lib/python3.11/re/__init__.py", line 185, in sub
    return _compile(pattern, flags).sub(repl, string, count)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'NoneType'

Trying to pip(lite)-install when the name of the package is None? How did that happen?

Although an error like that shouldn't be fixed by re-running, I'm going to try it anyway in case it's a bad release of JupyterLite that others have noticed and have already put out a patch for.

Just in case, I'll tag @agoose77.

@jpivarski jpivarski changed the title test: TEMPORARILY put an upper cap on NumPy 2.0 test: TEMPORARY edits to get tests working for all PRs: NumPy 2.0 cap and turned off Try-It Mar 20, 2024
@jpivarski jpivarski merged commit f49e07e into main Mar 20, 2024
38 checks passed
@jpivarski jpivarski deleted the jpivarski/temporarily-put-an-upper-cap-on-numpy branch March 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant