feat: Allow interoperability with numpy 2.x #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works in numpy 1.26.4 at least. There are warnings about accessing numpy internals, so we'll see what happens next.
This was removed from top-level namespace in numpy 2.0, but all versions allow np.exceptions.AxisError.
ak_full_like.py feels like it could use a touch of refactoring.
This should work (by not triggering) for numpy 1.x again.
Closed
|
I'll review it when it's done. (We use the "request review" button as a way to get my attention to review it when it's time to decide if it can be merged as-is or needs changes. The "ready for review" button doesn't send me an email, but "request review" does.) |
tcawlfield
changed the title
…an a simple look-up)
…cored) interfaces
…an a simple look-up)
…an a simple look-up)
…ght by NumPy 2.0, and not by 1.x
|
@ManasviGoyal, (real?) errors in these two kernel tests are being caught by NumPy 2.0, and not by 1.x: 2bcb015 |
jpivarski
approved these changes
Apr 1, 2024
|
Great to see this! I'm making a compatibility overview for numpy 2.0; can I ask what version of Awkward Array this will land in? |
|
Awkward 2.6.3, which is waiting on one more fix from #3068. I hope it will be done today. |
|
Awesome, thanks @jpivarski. |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to allow awkward to work correctly with numpy 2.x.