Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add some misc CUDA kernels #3141

Merged
merged 7 commits into from
Jun 7, 2024
Merged

feat: add some misc CUDA kernels #3141

merged 7 commits into from
Jun 7, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

No description provided.

@ManasviGoyal ManasviGoyal marked this pull request as ready for review June 6, 2024 16:00
@ManasviGoyal ManasviGoyal changed the title feat: add missing CUDA kernels feat: add some misc CUDA kernels Jun 6, 2024
jpivarski
jpivarski approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! (Add additions, and they look like good implementations. Why was tests-cuda/test_3086_cuda_flatten.py removed, though?)

I tested it on my GPU and it's ready to merge.

@ManasviGoyal
Copy link
Collaborator Author

ManasviGoyal commented Jun 6, 2024 •
edited
Loading

This is good! (Add additions, and they look like good implementations. Why was tests-cuda/test_3086_cuda_flatten.py removed, though?)

I tested it on my GPU and it's ready to merge.

I moticed that I added a few tests multiple times. So I just removed the repetitive ones and moved the rest to other tests files. So the flatten tests are still there but moved to different test files as per the functions they were testing like concatenate, slicing etc.

@ManasviGoyal ManasviGoyal merged commit ef1e851 into main Jun 7, 2024
41 checks passed
@ManasviGoyal ManasviGoyal deleted the ManasviGoyal/misc-kernels branch June 7, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManasviGoyal @jpivarski