-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to hatchling #423
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
I have to go and will look into this later ... As a general comment - it would make sense to me to first discuss changes/moves such as this one among us prior to being exposed to the fact. I can't see a counter argument. Kindly have this in mind in the future. It goes without saying that I'm never against improvements. Would be worried about disruptions, in the broad sense, though. This seems welcome but allow me time to look ... |
Sorry, this has been happening across other Scikit-HEP repos, like scikit-hep/uproot5#688, scikit-hep/hist#418, and scikit-hep/vector#223. Didn't know it would need further discussion here. I'm interested in moving all of our pure Python packages over. |
And have no idea why Actions isn't running anything ATM. Edit: okay, finally ran. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Codecov ReportBase: 90.36% // Head: 90.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 90.36% 90.78% +0.41%
==========================================
Files 29 29
Lines 1329 1324 -5
==========================================
+ Hits 1201 1202 +1
+ Misses 128 122 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unfamiliar with hatchling but seems fine from reading changes themselves. It's kind of self-explanatory.
No more need for the MANIFEST file?
That’s a setuptools thing. The SDist will have a bit more in it, but that’s fine. The wheel should be just like before. Hatchling uses the .gitignore file to decide what to include. You can manually add config to the pyproject file to exclude or add files, but it does a good job by default. |
Moving over to using hatchling.