Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to hatchling #423

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 5, 2022

Moving over to using hatchling.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii closed this Oct 5, 2022
@henryiii henryiii reopened this Oct 5, 2022
@eduardo-rodrigues
Copy link
Member

eduardo-rodrigues commented Oct 5, 2022

I have to go and will look into this later ... As a general comment - it would make sense to me to first discuss changes/moves such as this one among us prior to being exposed to the fact. I can't see a counter argument. Kindly have this in mind in the future.

It goes without saying that I'm never against improvements. Would be worried about disruptions, in the broad sense, though. This seems welcome but allow me time to look ...

@henryiii
Copy link
Member Author

henryiii commented Oct 5, 2022

Sorry, this has been happening across other Scikit-HEP repos, like scikit-hep/uproot5#688, scikit-hep/hist#418, and scikit-hep/vector#223. Didn't know it would need further discussion here. I'm interested in moving all of our pure Python packages over.

@henryiii
Copy link
Member Author

henryiii commented Oct 5, 2022

And have no idea why Actions isn't running anything ATM. Edit: okay, finally ran.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 90.36% // Head: 90.78% // Increases project coverage by +0.41% 🎉

Coverage data is based on head (da0950b) compared to base (0e651a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   90.36%   90.78%   +0.41%     
==========================================
  Files          29       29              
  Lines        1329     1324       -5     
==========================================
+ Hits         1201     1202       +1     
+ Misses        128      122       -6     
Impacted Files Coverage Δ
src/particle/pdgid/functions.py 87.17% <0.00%> (ø)
src/particle/particle/particle.py 91.58% <0.00%> (+0.91%) ⬆️
src/particle/converters/bimap.py 91.20% <0.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with hatchling but seems fine from reading changes themselves. It's kind of self-explanatory.

No more need for the MANIFEST file?

@henryiii
Copy link
Member Author

henryiii commented Oct 7, 2022

That’s a setuptools thing. The SDist will have a bit more in it, but that’s fine. The wheel should be just like before. Hatchling uses the .gitignore file to decide what to include. You can manually add config to the pyproject file to exclude or add files, but it does a good job by default.

@eduardo-rodrigues eduardo-rodrigues merged commit 723c161 into master Oct 7, 2022
@eduardo-rodrigues eduardo-rodrigues deleted the henryiii/feat/hatchling branch October 7, 2022 06:13
@eduardo-rodrigues eduardo-rodrigues added ⚙️ enhancement New feature or request tests labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants