Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify HoeffdingTreeRegressor #194

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

AlbandeCrevoisier
Copy link
Collaborator

Used for reference.

Minor improvements:

  • use iterators instead of index
  • return right at the if test instead of shoving it back to an else and indent all the code
  • ...

Checklist

  • Code complies with PEP-8 and is consistent with the framework.
  • Code is properly documented.
  • Tests are included for new functionality or updated accordingly.
  • Travis CI build passes with no errors.
  • Test Coverage is maintained (threshold is -0.2%).
  • Files changed (update, add, delete) are in the PR's scope (no extra files are included).

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #194 into master will decrease coverage by 0.03%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   85.11%   85.08%   -0.04%     
==========================================
  Files         173      173              
  Lines       12836    12838       +2     
==========================================
- Hits        10926    10923       -3     
- Misses       1910     1915       +5
Impacted Files Coverage Δ
src/skmultiflow/trees/hoeffding_tree_regressor.py 83.7% <90.47%> (-0.3%) ⬇️
src/skmultiflow/meta/online_rus_boost.py 85.71% <0%> (-1.79%) ⬇️
src/skmultiflow/trees/isoup_tree.py 84.39% <0%> (-0.36%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant