Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min_cluster_samples must be an int #224

Merged
merged 5 commits into from
May 10, 2021
Merged

fix: min_cluster_samples must be an int #224

merged 5 commits into from
May 10, 2021

Conversation

deargle
Copy link
Collaborator

@deargle deargle commented Apr 10, 2021

closes #223

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #224 (13e4a1a) into master (56dbd66) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   79.62%   79.79%   +0.16%     
==========================================
  Files          11       11              
  Lines         854      861       +7     
  Branches      186      189       +3     
==========================================
+ Hits          680      687       +7     
  Misses        141      141              
  Partials       33       33              
Impacted Files Coverage Δ
kmapper/kmapper.py 89.71% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56dbd66...13e4a1a. Read the comment docs.

@deargle
Copy link
Collaborator Author

deargle commented Apr 10, 2021

Sorry for the commit spam, local tests weren't working so I was abusing github's testing.

@sauln approve?

@deargle deargle merged commit 94461a5 into master May 10, 2021
@sauln sauln deleted the fix-min-samples branch May 10, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: min_cluster_samples should not be set to a non-integer
1 participant