Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cubes overlap cleaned up #232

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

erooke
Copy link
Contributor

@erooke erooke commented Aug 13, 2021

test_cubes_overlap may mistakenly call set union instead of set
intersection. Added a short docstring explaining what the test does and
made a small stylistic change.

`test_cubes_overlap` mistakenly called set union instead of set
intersecrtion. Added a short docstring explaining what the test does and
made a small stylistic change.
@deargle deargle merged commit 7c3496a into scikit-tda:master Oct 8, 2021
@deargle
Copy link
Collaborator

deargle commented Oct 8, 2021

Thanks!

@erooke erooke deleted the test_cubes_overlap branch October 8, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants