Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MOI test usage #111

Merged
merged 11 commits into from
Mar 29, 2019
Merged

Improve MOI test usage #111

merged 11 commits into from
Mar 29, 2019

Conversation

rschwarz
Copy link
Collaborator

Still need to exlude tests for a variety of reasons (can't query vars by name, SCIP's SOC constraints make strong assumptions about var bounds, can't delete vars from constraints), but feel more future-proof w.r.t. to new tests being added to MOI 😄

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #111 into master will increase coverage by 0.21%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   13.11%   13.32%   +0.21%     
==========================================
  Files         133      133              
  Lines        4217     4217              
==========================================
+ Hits          553      562       +9     
+ Misses       3664     3655       -9
Impacted Files Coverage Δ
src/MOI_wrapper/variable.jl 77.19% <0%> (ø) ⬆️
src/wrapper/cons_linear.jl 45.45% <0%> (+13.63%) ⬆️
src/MOI_wrapper/linear_constraints.jl 80.48% <0%> (+14.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecff7e...30b3cf6. Read the comment docs.

@rschwarz rschwarz merged commit 746efd0 into master Mar 29, 2019
@rschwarz rschwarz deleted the rs/bridged_MOI_tests branch March 29, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant