Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagerduty notification not being sent for WARN #278

Closed
anitakrueger opened this issue Apr 9, 2015 · 6 comments
Closed

Pagerduty notification not being sent for WARN #278

anitakrueger opened this issue Apr 9, 2015 · 6 comments

Comments

@anitakrueger
Copy link

I have configured pagerduty notifications for a check and alerts with ERROR level are being sent to pagerduty and create an incident.
The subscription was created with "Notify on" set to "Warn", "Error" and "OK", but for warning, no notifications are sent.
This is what I see in seyren.log:

 09/04/2015 13:56:29.149 [seyren.check-scheduler-1] WARN   c.s.c.s.n.PagerDutyNotificationService - Did not send notification to PagerDuty for check in state: WARN

I looked this up in the code and it looks like warning levels are not included in the PagerDutyNotificationService:
https://github.com/scobal/seyren/blob/master/seyren-core/src/main/java/com/seyren/core/service/notification/PagerDutyNotificationService.java#L69
https://github.com/scobal/seyren/blob/master/seyren-core/src/main/java/com/seyren/core/service/notification/PagerDutyNotificationService.java#L77
Only Error and OK are checked.

Could this be fixed or am I missing something?

Thanks

  • Anita
@obazoud
Copy link
Contributor

obazoud commented Apr 13, 2015

hi @anitakrueger
Since years, it's seems that 'Warning' level was ignored by PagerDutyNotificationService :(

obazoud added a commit to obazoud/seyren that referenced this issue Apr 13, 2015
obazoud added a commit that referenced this issue Apr 13, 2015
Pagerduty notification sent for WARN #278
@obazoud
Copy link
Contributor

obazoud commented Apr 13, 2015

See #284

@anitakrueger
Copy link
Author

Hi Olivier,
Thanks a lot for the quick fix! That is awesome!
Do you build a new seyren.jar regularly or is there a release schedule?

Thanks a bunch

  • Anita

@obazoud
Copy link
Contributor

obazoud commented Apr 14, 2015

@anitakrueger
Copy link
Author

Wow. Thanks!

@obazoud
Copy link
Contributor

obazoud commented Apr 16, 2015

@anitakrueger Feel free to reopen this issue if you have a problem with 1.3.0.

@obazoud obazoud closed this as completed Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants