Update dependencies and skip symlink test on windows #4
Conversation
| expect(stats.isFile()).toEqual(true); | ||
| expect(stats.isSymbolicLink()).toEqual(false); | ||
| }); | ||
| if (platform() !== 'win32') { |
There was a problem hiding this comment.
It's too bad jest doesn't seem to have mocha's skip() feature.
There was a problem hiding this comment.
Jest's .skip only supports static skipping. If you look at mocha's (.skip)[https://mochajs.org/#inclusive-tests] it lets you conditionally call it. The way this code is now, the test is silently omitted on windows (which isn't ideal).
There was a problem hiding this comment.
Ah I understand. That's a cool feature and I didn't knew that. Maybe skip-if is what you are looking for 😉 Unfortunately it's not build in into Jest: jestjs/jest#3652
There was a problem hiding this comment.
Yeah, I didn't want to add a dependency to your module just for this. Thanks for releasing a new version!
|
Because I added some stuff I also did an upgrade to all dependencies and copied your if statement for Windows. Thank you for your help! 👍 |
This PR fixes the "outdated dependencies" warning badge and should let you run tests on appveyor if you want.
Thanks for making
cp-cli!