Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(config): moved fee vault addr to rollup config #341

Merged
merged 4 commits into from
May 22, 2023
Merged

refactor(config): moved fee vault addr to rollup config #341

merged 4 commits into from
May 22, 2023

Conversation

rrzhang139
Copy link

Currently we have L2 ScrollFeeVaultAddress in the L2 genesis configuration. However, this is a predeployed contract with a fixed address, so user does not need to configure it. We can move this config into rollup/rcfg/config.go

@rrzhang139 rrzhang139 requested a review from Thegaram May 20, 2023 15:47
@rrzhang139 rrzhang139 requested a review from HAOYUatHZ May 21, 2023 01:56
@HAOYUatHZ HAOYUatHZ changed the title moved fee vault addr to rollup config refactor(config): moved fee vault addr to rollup config May 22, 2023
Thegaram
Thegaram approved these changes May 22, 2023
View reviewed changes
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My idea is that we can remove UsingFeeVault (i.e. stop supporting the old behaviour). But we can keep it as it is for now and remove it in the future.

@HAOYUatHZ
Copy link
Member

Looks good. My idea is that we can remove UsingFeeVault (i.e. stop supporting the old behaviour). But we can keep it as it is for now and remove it in the future.

Agree

@HAOYUatHZ HAOYUatHZ merged commit 2f70857 into develop May 22, 2023
@HAOYUatHZ HAOYUatHZ deleted the move-feeVaultAddress-to-rollup-config branch May 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thegaram Thegaram Thegaram approved these changes

@HAOYUatHZ HAOYUatHZ HAOYUatHZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrzhang139 @HAOYUatHZ @Thegaram