Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct state root after execution #507

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: use correct state root after execution #507

merged 3 commits into from
Sep 11, 2023

Conversation

Thegaram
Copy link

No description provided.

zimpha
zimpha reviewed Sep 11, 2023
View reviewed changes
core/trace.go Show resolved Hide resolved
@colinlyguo
Copy link
Member

colinlyguo commented Sep 11, 2023 •
edited
Loading

CI failed with:

Error: cmd/geth/chaincmd.go:461:14: ineffectual assignment to err (ineffassign)
tracesJson, err := json.Marshal(traces)

btw, found a typo related to trace PRs:

// BlockNumber is the hash of the block in which this transaction was skipped or nil.
BlockHash *common.Hash

georgehao
georgehao reviewed Sep 11, 2023
View reviewed changes
cmd/geth/chaincmd.go Outdated Show resolved Hide resolved
@Thegaram Thegaram merged commit 82a4956 into trace-tx-command Sep 11, 2023
5 checks passed
@Thegaram Thegaram deleted the trace-tx-command-fix-1 branch September 11, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehao georgehao georgehao left review comments

@HAOYUatHZ HAOYUatHZ HAOYUatHZ approved these changes

@zimpha zimpha zimpha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thegaram @colinlyguo @zimpha @georgehao @HAOYUatHZ