Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: limit ping requests from a single peer #510

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

iczc
Copy link

@iczc iczc commented Sep 12, 2023

1. Purpose or design rationale of this PR

Cherry-pick ethereum#27887.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

fjl and others added 2 commits September 12, 2023 23:47
Moving the response sending there allows tracking all peer goroutines
in the peer WaitGroup.
@Thegaram Thegaram merged commit 734021f into develop Sep 12, 2023
5 checks passed
@Thegaram Thegaram deleted the p2p-ping-loop branch September 12, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants