forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup configuration for upcoming hard fork and re-enable sha256 precompile #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NazariiDenha
changed the title
feat: setup configuration for upcoming hard fork
feat: setup configuration for upcoming hard fork and re-enable sha256 precompile
Nov 15, 2023
…t/conf-for-hard-fork
Looks good. Can we find a better placeholder name than "Hardfork"? Let's use "Kepler" for now (might rename it later). |
ok, just didn't know how to name it |
NazariiDenha
force-pushed
the
feat/conf-for-hard-fork
branch
from
November 30, 2023 14:00
2f34726
to
95f1e9e
Compare
HAOYUatHZ
previously approved these changes
Dec 11, 2023
Thegaram
previously approved these changes
Feb 9, 2024
colinlyguo
reviewed
Feb 9, 2024
Thegaram
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
In order to be able to add these features to l2geth without breaking compatibility with our current networks, we need to add a fork number / timestamp configuration, similarly to how we activated Archimedes. We can activate the new fork at block 0 on new testnets, while on Scroll and Scroll Sepolia the activation block number will be determined later.
https://app.asana.com/0/1202293017617135/1205896809138433/f
sha256
precompile.In the Archimedes hard fork we disabled the SHA-256 precompile. In the next hard fork, we want to re-enable it.
https://app.asana.com/0/1202293017617135/1205896809138436/f
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?