Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (libzkp-v0.9.8): recordStorageDetail even when LogConfig.DisableStorage == true #564

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

lispc
Copy link

@lispc lispc commented Nov 16, 2023

1. Purpose or design rationale of this PR

Set DisableStorage: true, related zkevm-circuits PR scroll-tech/zkevm-circuits#1035

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc marked this pull request as draft November 16, 2023 08:42
@silathdiir silathdiir marked this pull request as ready for review November 17, 2023 05:11
@silathdiir silathdiir changed the title trace: recordStorageDetail even when LogConfig.DisableStorage == true [WIP] trace: recordStorageDetail even when LogConfig.DisableStorage == true Nov 17, 2023
@silathdiir silathdiir changed the title [WIP] trace: recordStorageDetail even when LogConfig.DisableStorage == true [WIP] trace: recordStorageDetail even when LogConfig.DisableStorage == true (release v0.9.8) Nov 20, 2023
@silathdiir silathdiir changed the title [WIP] trace: recordStorageDetail even when LogConfig.DisableStorage == true (release v0.9.8) [WIP] feat (libzkp-v0.9.8): recordStorageDetail even when LogConfig.DisableStorage == true Nov 20, 2023
@silathdiir silathdiir changed the title [WIP] feat (libzkp-v0.9.8): recordStorageDetail even when LogConfig.DisableStorage == true feat (libzkp-v0.9.8): recordStorageDetail even when LogConfig.DisableStorage == true Nov 20, 2023
@georgehao georgehao merged commit 9f143b4 into develop Nov 22, 2023
5 checks passed
@georgehao georgehao deleted the trace/disable-storage branch November 22, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants