Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix goimports lint in CI #628

Merged
merged 4 commits into from
Feb 9, 2024
Merged

ci: fix goimports lint in CI #628

merged 4 commits into from
Feb 9, 2024

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Feb 1, 2024

1. Purpose or design rationale of this PR

Use Go 1.18 for goimports-lint only to maintain the original formatting. We can reformat once later in another PR.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Feb 1, 2024
georgehao
georgehao previously approved these changes Feb 1, 2024
@HAOYUatHZ
Copy link
Member

maybe disable go mod tidy then we are good to go

@Thegaram Thegaram dismissed stale reviews from georgehao and colinlyguo via e706540 February 9, 2024 12:13
@Thegaram Thegaram merged commit 7e3a7ae into develop Feb 9, 2024
6 checks passed
@Thegaram Thegaram deleted the fix-ci-goimports-lint branch February 9, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants