Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Clique block interval as a timeout #692

Closed
wants to merge 1 commit into from

Conversation

omerfirmak
Copy link

No description provided.

@omerfirmak omerfirmak marked this pull request as ready for review April 8, 2024 20:53
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense, though we should treat it as a breaking change and not merge yet.

@omerfirmak
Copy link
Author

omerfirmak commented Apr 14, 2024

This change makes sense, though we should treat it as a breaking change and not merge yet.

4844 upgrade will most likely attract significant demand. It might be bad PR if there is congestion on the network. It might make sense to bundle it together with the 4844 update or not delay it too much after the 4844 upgrade.

@omerfirmak
Copy link
Author

closing in favor of #735

@omerfirmak omerfirmak closed this May 3, 2024
@HAOYUatHZ HAOYUatHZ deleted the omerfirmak/block-interval branch August 5, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants