Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay Curie fork on mainnet by 1 day #821

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Thegaram
Copy link

1. Purpose or design rationale of this PR

Delay +1 day to accommodate verifier contract timelock delay.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@colinlyguo
Copy link
Member

interesting. the time interval is not exactly 24 * 3600 secs. Could I ask where's the small diff come from?

@Thegaram
Copy link
Author

interesting. the time interval is not exactly 24 * 3600 secs. Could I ask where's the small diff come from?

Yeah, in hindsight, I could have just added 24 * 3600. Instead I calculated a new target date using the current timestamp and the current latest block number.

@colinlyguo
Copy link
Member

colinlyguo commented Jun 12, 2024

interesting. the time interval is not exactly 24 * 3600 secs. Could I ask where's the small diff come from?

Yeah, in hindsight, I could have just added 24 * 3600. Instead I calculated a new target date using the current timestamp and the current latest block number.

this makes more sense. since the real block generation time would draft a bit later. we can always make the expected diff smaller.

@Thegaram Thegaram merged commit 69aae68 into develop Jun 12, 2024
8 checks passed
@Thegaram Thegaram deleted the feat-delay-curie-by-one-day branch June 12, 2024 09:37
lwedge99 added a commit to sentioxyz/scroll-geth that referenced this pull request Jun 19, 2024
feat: delay Curie fork on mainnet by 1 day (scroll-tech#821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants