-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configure l2geth Docker pipeline to push latest tag #831
Conversation
changed it to push latest tag on published releases |
I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be possible with https://cli.github.com/manual/gh_workflow_run if you add on.workflow_dispatch
gh workflow run docker.yaml --ref push-latest-tag
0740008
to
6fb63ce
Compare
fixed, now
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I'm not sure how latest=false
plays with type=raw,value=latest
. After merging can we trigger this manually to test on a suitable version?
as explained here "Finally, to have the latest tag set only for the main branch and a release, I disable the default "latest flavor" (which always adds the tag latest) and provide instead the expression" and also from the metadata action docs https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag |
To trigger it just publish a release on a suitable version |
* push latest tag * push latest tag on release published * use metadata-action to define tags * test * push ref name on push tag or push latest tag on publishing release
* feat: Configure l2geth Docker pipeline to push latest tag (#831) * push latest tag * push latest tag on release published * use metadata-action to define tags * test * push ref name on push tag or push latest tag on publishing release * update --------- Co-authored-by: Nazarii Denha <dengaaa2002@gmail.com>
…h#831) * push latest tag * push latest tag on release published * use metadata-action to define tags * test * push ref name on push tag or push latest tag on publishing release
1. Purpose or design rationale of this PR
Configure l2geth Docker pipeline to push latest tag
#810
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?