Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure l2geth Docker pipeline to push latest tag #831

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

NazariiDenha
Copy link

1. Purpose or design rationale of this PR

Configure l2geth Docker pipeline to push latest tag
#810

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@NazariiDenha NazariiDenha reopened this Jun 18, 2024
@NazariiDenha
Copy link
Author

changed it to push latest tag on published releases

@NazariiDenha
Copy link
Author

I used docker/metadata-action as @jonastheis suggested. Not sure how I can test it?

Copy link

@jonastheis jonastheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be possible with https://cli.github.com/manual/gh_workflow_run if you add on.workflow_dispatch

gh workflow run docker.yaml --ref push-latest-tag

@NazariiDenha
Copy link
Author

fixed, now

  • tag name is pushed to docker on new tags push as earlier (tested)
  • additionally, on release published, latest tag is pushed to docker too (this not tested to prevent shadowing latest tag and to not create new release, but looks like it should work)

Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm not sure how latest=false plays with type=raw,value=latest. After merging can we trigger this manually to test on a suitable version?

@NazariiDenha
Copy link
Author

as explained here "Finally, to have the latest tag set only for the main branch and a release, I disable the default "latest flavor" (which always adds the tag latest) and provide instead the expression"

and also from the metadata action docs https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag

@NazariiDenha
Copy link
Author

After merging can we trigger this manually to test on a suitable version?

To trigger it just publish a release on a suitable version

@Thegaram Thegaram merged commit e30e1f1 into develop Jul 3, 2024
8 checks passed
@Thegaram Thegaram deleted the push-latest-tag branch July 3, 2024 19:47
HAOYUatHZ pushed a commit that referenced this pull request Jul 31, 2024
* push latest tag

* push latest tag on release published

* use metadata-action to define tags

* test

* push ref name on push tag or push latest tag on publishing release
HAOYUatHZ added a commit that referenced this pull request Jul 31, 2024
* feat: Configure l2geth Docker pipeline to push latest tag (#831)

* push latest tag

* push latest tag on release published

* use metadata-action to define tags

* test

* push ref name on push tag or push latest tag on publishing release

* update

---------

Co-authored-by: Nazarii Denha <dengaaa2002@gmail.com>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
…h#831)

* push latest tag

* push latest tag on release published

* use metadata-action to define tags

* test

* push ref name on push tag or push latest tag on publishing release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants