feat(txpool): StatsWithMinBaseFee #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
reviewed
Jul 5, 2024
omerfirmak
previously approved these changes
Jul 8, 2024
HAOYUatHZ
previously approved these changes
Jul 8, 2024
Thegaram
previously approved these changes
Jul 9, 2024
github-actions
bot
dismissed stale reviews from HAOYUatHZ, omerfirmak, and Thegaram
via
6ddc697
omerfirmak
approved these changes
Jul 10, 2024
HAOYUatHZ
approved these changes
Jul 10, 2024
Thegaram
approved these changes
Jul 10, 2024
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
* feat(txpool): implement StatsWithMinBaseFee * feat(gpo): use StatsWithMinBaseFee to filter out tx below the current blocks base fee * feat(les/txpool): implement StatsWithMinBaseFee * use flatten() (lowercase) to avoid copying of tx list * chore: auto version bump [bot] --------- Co-authored-by: jonastheis <jonastheis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
When the base fee changes, transactions which are now below the base fee, stay in the txpool as
pending. However, since we use the amount ofpendingtx in the GPO to determine the current congestion level of the network, this wouldn't yield any meaningful information anymore.This PR, therefore, introduces a function
StatsWithMinBaseFeeto the txpool so that the GPO can query thependingtransactions that are meaningful right now.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?