JSON and YAML export_set fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgojmerac
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
+1
Fixes look ok to me, added one comment where some reordering may be occurring but otherwise nothing jumped out.
The new tests added to cover the errors hit in the export_set functions look adequate to me for new coverage for validating the bug fix, so I don't think we need to add any additional tests right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
json.dumps()function directly inexport_set().yaml.dump()andyaml.safe_dump()function directly inexport_set().orderedas plain dicts are already ordered since Python 3.6 - Removed OrderedDict usage jazzband/tablib#581.Related Links
Ready for QA Checklist