[Documentation] Update Installation #265
Conversation
CI MessageAborting, need an authorized user to run CI |
|
@JackKuo-tw thanks for looking into this. I thought we got rid of our Python 2 dependencies, do you remember, or have screenshots of where it was necessary? I think it would be better to remove those instances if possible, rather than adding the python 2 package. |
|
@kevindweb Please refer to the screenshot below, it looks like Although, in this transition period (py2 -> py3), I think add a comment to remind the user is the best way. After I change the doc, I'll notify you again, thanks.
|
|
@kevindweb done, please have a look. |
docs/Install.md
Outdated
| @@ -130,6 +130,8 @@ Configure and compile DPDK | |||
|
|
|||
| The [install script](../scripts/install.sh) will automatically run the [environment setup script](../scripts/setup_environment.sh), which configures your local environment. This should be run once for every reboot, as it loads the appropraite kernel modules and can bind your NIC ports to the DPDK driver. | |||
|
|
|||
| If `which python` shows **not found** in your environment, please link `python` it to your Python2 or Python3, e.g., via `link -s` or `alias python=$(which python3)`. | |||
There was a problem hiding this comment.
| If `which python` shows **not found** in your environment, please link `python` it to your Python2 or Python3, e.g., via `link -s` or `alias python=$(which python3)`. | |
| If `which python` shows **not found** in your environment, please link `python` to Python3, e.g., via `link -s` or `alias python=$(which python3)`. |
There was a problem hiding this comment.
I think maybe changing the wording to this might let people know that Python2 isn't really relevant anymore.
There was a problem hiding this comment.
@kevindweb Looks great! I've modified it 😁
1. Fill in missing package 2. Update unprecise word
Summary:
This PR is tested on clean Vagrant Box
bento/ubuntu-20.04, add some missing packages needed by ONVMThere is one thing interesting, the original installation doc said ONVM needs Python3, but in my test it also needs Python2, so I added it.
Usage:
Merging notes:
TODO before merging :
Test Plan:
Review:
Anyone.