Skip to content

Commit

Permalink
Rework sliding window approach of 'split.data.activity.based'
Browse files Browse the repository at this point in the history
Rework the algorithm to create sliding windows in activity-based splitting.
Instead of cutting off half a range many elements at the end before building
sliding windows (which creates a lot of edge cases), build sliding windows with
every element up to the last one. Then remove the last incomplete range.
The contents of the last incomplete range will be fully included in the second
last range and therefore redundant.
Sometimes the last incomplete range is a regular range. Previously the last
range always had to be a regular range. This means that removing the last
incomplete range requires updating the tests.

Additionally fix and improve documentation of splitting methods and fix
minor spelling bugs.

This works towards #239.

Signed-off-by: Maximilian Löffler <s8maloef@stud.uni-saarland.de>
  • Loading branch information
MaLoefUDS committed Oct 18, 2023
1 parent 771bcc8 commit 48ef4fa
Show file tree
Hide file tree
Showing 2 changed files with 90 additions and 135 deletions.
Loading

0 comments on commit 48ef4fa

Please sign in to comment.