Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow canceling actions from the GUI #215

Closed
sea-bass opened this issue Jul 14, 2024 · 6 comments · Fixed by #247
Closed

Allow canceling actions from the GUI #215

sea-bass opened this issue Jul 14, 2024 · 6 comments · Fixed by #247
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sea-bass
Copy link
Owner

Since #214 was merged in, we now have all the backend APIs to do this, either for single actions that were kicked off by pushing GUI buttons, or because something in the backend sent an action or task plan to the robot(s).

The "hard" part is just figuring out where in the GUI to put this cancel button.

The test/system/test_system.py file should probably also have a test for clicking this cancel button.

@sea-bass sea-bass added enhancement New feature or request good first issue Good for newcomers labels Jul 14, 2024
@muhidabid
Copy link
Contributor

I am thinking the cancel button could be on the bottom right corner of the world, opposite to the "show collision polygons" checkbox. We can print a short message for the actions letting the user know something is in progress along with the cancel button. What do you think?

@sea-bass
Copy link
Owner Author

Was thinking something like that, especially since I think after one of the new PRs there may also be a need for a "reset path planner" button as well

@muhidabid
Copy link
Contributor

Maybe an undo would be nice instead of different implementations of cancel and reset path planner. You can undo any of your actions once they are done. Just thinking out loud

@sea-bass
Copy link
Owner Author

Undo would require some significant backend changes (and I at least don't see a use case for it right now).

Canceling a currently executing path and resetting path planners are already implemented.

@muhidabid
Copy link
Contributor

muhidabid commented Aug 20, 2024

Alright. I will work on this issue. Should I also look into reset path planner or will there be a separate issue for that?

I was looking at the commit you made in #214. Is this the API to be called upon cancel?

def cancel_actions(self):

@sea-bass
Copy link
Owner Author

Yep, that's the one!

And let's save the reset path planner til later since that PR is still waiting for review

muhidabid added a commit to muhidabid/pyrobosim that referenced this issue Aug 21, 2024
@sea-bass sea-bass linked a pull request Aug 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants