-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up planner plotting #121
Conversation
There is a small bug from #119 which causes a "referenced before assignment" bug. I ran the ROS multirobot demo after adding that, there were no errors, but the rendering was spooky, with robots teleporting to different locations, see this video |
Nice catch on the bug! I pushed that fix directly to main. The teleporting error is also happening on |
Actually, this issue is because we're publishing commands before the GUI is started, and that causes things to go out of sync. I'll find a fix to wait til the GUI is running before sending this out. |
@ibrahiminfinite Try again? Just made some changes. |
Ran it again, works smooth and the graph plotting is FAST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR significantly speeds up plotting using the technique described in https://stackoverflow.com/questions/53035858/plot-multiple-values-with-matplotlib-without-loop
To test, you can specifically try some of the multirobot demos / demos with PRMs in them.