Fix circular imports in knowledge utilities #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
force-pushed
the
fix-circular-imports
branch
from
c7f74e0
to
4d5179f
Compare
sea-bass
force-pushed
the
fix-circular-imports
branch
from
4d5179f
to
9548c79
Compare
henrygerardmoore
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes circular imports in the knowledge utilities by importing from the core modules only in the functions that require it.
It also ensures that Location and Object metadata is always set to a blank dictionary even when nothing has been specified, to prevent runtime errors.
Closes #122