Split out remote regexp in to smaller parts #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By splitting by fields, we get a nice slice of [name URL purpose] which makes the regexp for matching a URL more manageable.
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 81.79% 81.84% +0.04%
==========================================
Files 4 4
Lines 758 760 +2
==========================================
+ Hits 620 622 +2
Misses 114 114
Partials 24 24
|
|
Looks very good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By splitting by fields, we get a nice slice of [name URL purpose] which makes the regexp for matching a URL more manageable and work with github URLs without usernames #107
(sorry it's been about 4-5 years since I last touched any Go)