-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please increase the demo number of headers #70
Comments
@jrconlin I see 64 here, https://docs.rs/httparse/1.3.4/httparse/constant.EMPTY_HEADER.html#example Is there anywhere else 16 is listed, beyond the README.md, that you're aware of? |
Not that I'm aware of, no. However, I've not really done a very deep dive to investigate. It's my guess that we used |
Got the same problem too. The fact that Chrome sent more headers than cURL and exceeded the pre-allocated number of headers really confused us for a while. |
tldr: Please change the documentation demo line from
to
This is a really silly bug that bit us.
Our server uses httparse. Since we weren't quite sure how many headers we needed to pre-allocate, we used the demo code's suggested 16 headers. Unfortunately, with work going on around the new
Sec-*
headers, we suddenly saw a spike of clients trying to connect with 17 headers. It took us a bit to figure out what was going on and why these connections were mysteriously failing.Boosting the count might help others not suddenly hit this problem.
The text was updated successfully, but these errors were encountered: