Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bytes inner arithmetic #138

Merged
merged 2 commits into from
Apr 25, 2023
Merged

refactor: Bytes inner arithmetic #138

merged 2 commits into from
Apr 25, 2023

Commits on Apr 25, 2023

  1. refactor: Bytes inner arithmetic 

    IMO cleaner pointer arithmetic avoiding unnecessary intermediate slices.

No perf gains in isolation but facilitates some (upcoming PRs)

This is conceptually easier to reason about, end is fixed, "start" and "cursor" advance monotonically
    @AaronO
    AaronO committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    de04f3a View commit details
    Browse the repository at this point in the history

  2. safe Bytes::peek_n()

    @AaronO
    AaronO committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    7152377 View commit details
    Browse the repository at this point in the history