Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom filter group_by #692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arthurmmedeiros
Copy link

Hello there,

I previously added this question, but I realised the code I wrote was just wrong. I fixed it and decided to create a pull request with this new custom filter.

I think this is a useful feature, so I felt I could share and give a small contribution to this library.

I added some tests and I'm happy to add more if necessary.

Thank you.

@hishamco
Copy link
Collaborator

What's the problem that you going to fix?

@arthurmmedeiros
Copy link
Author

@hishamco sorry, I should have given more details about this pull request in my first comment.

The problem I am trying to solve is to group a list of objects by a certain key. In the tests I used an example where I had a list of users, and I wanted to group these users by type (admin and client).

I hope this makes more sense.

@hishamco
Copy link
Collaborator

@sebastienros do you have any objection to introduce this filter, before I review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants