-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.4.0 plugin fails to load, previous rev is fine. #20
Comments
What Node & NPM versions to you have? |
Node.js Version v14.18.2
Npm Version v6.14.15
If they are too old now for this plugin, hopefully the plugin updater would warn :)
… On Jan 29, 2022, at 9:57 AM, Sebastian ***@***.***> wrote:
What Node & NPM versions to you have?
—
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJWC2EAQFQFMIPPMXNG5MPLUYQTAJANCNFSM5NDE5MFA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.
|
I've published a change reverting the ES Module. Out of curiosity though - can you check what your |
I’m on 0.3.5 release currently without any issues
Ben.
…Sent from my iPhone
On Jan 30, 2022, at 1:33 PM, Sebastian ***@***.***> wrote:
I've published a change reverting the ES Module. Out of curiosity though - can you check what your homebridge-eufy version is?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
Ah ok - I think from version 0.4.0 it would have worked, but this "ES module" reversal update should fix the issue again. ES module change is deferred to a major version update. Let me know if it works! |
I still only see the 0.4.0 release label. I updated to it again and got the same ES module error originally reported.
Downgraded down to 0.3.5 again and no issues.
Ben.
…Sent from my iPhone
On Jan 30, 2022, at 1:38 PM, Sebastian ***@***.***> wrote:
Ah ok - I think from version 0.4.0 it would have worked, but this "ES module" reversal update should fix the issue again. ES module change is deferred to a major version update.
Let me know if it works!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
Can you check what the version of It looks to me like there's a mismatch between node-eufy-api and homebridge-eufy here, which is quite confusing! |
Here is what I see for that node-eufy-api version in json file when I update to 0.4.0 (and it still fails).
{
"_from": "node-eufy-api@^0.4.0",
"_id": ***@***.***",
"_inBundle": false,
"_integrity": "sha512-m5Kg5USpK8r+rxEoF1fJtIZpt5Gb/DT+ze1T6b0h4tVc2skicdqxtRd0YB1j+pY6v/dqOzRUuMc1PQ+6BlXwMg==",
"_location": "/homebridge-eufy/node-eufy-api",
"_phantomChildren": {},
"_requested": {
"type": "range",
"registry": true,
"raw": "node-eufy-api@^0.4.0",
"name": "node-eufy-api",
"escapedName": "node-eufy-api",
"rawSpec": "^0.4.0",
"saveSpec": null,
"fetchSpec": "^0.4.0"
},
… On Jan 30, 2022, at 3:36 PM, Sebastian ***@***.***> wrote:
Can you check what the version of node-eufy-api is? I think that would be in this file, based on the error message you posted: /usr/lib/node_modules/homebridge-eufy/node_modules/node-eufy-api/package.json
It looks to me like there's a mismatch between node-eufy-api and homebridge-eufy here, which is quite confusing!
—
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJWC2EHHNWERKPRFEAZTKSLUYXDRFANCNFSM5NDE5MFA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.
|
Deleted plugin entirely, and installed @ale770/homebridge-eufy v0.3.7 |
ERROR LOADING PLUGIN homebridge-eufy:
[1/29/2022, 9:52:37 AM] Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /usr/lib/node_modules/homebridge-eufy/node_modules/node-eufy-api/lib/index.js
require() of ES modules is not supported.
require() of /usr/lib/node_modules/homebridge-eufy/node_modules/node-eufy-api/lib/index.js from /usr/lib/node_modules/homebridge-eufy/lib/index.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename /usr/lib/node_modules/homebridge-eufy/node_modules/node-eufy-api/lib/index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /usr/lib/node_modules/homebridge-eufy/node_modules/node-eufy-api/package.json.
The text was updated successfully, but these errors were encountered: