Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TLS13] Client key update & PSK #2586

Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Apr 11, 2020

Requires #2585

@gpotter2 gpotter2 marked this pull request as draft April 11, 2020 21:42
@gpotter2 gpotter2 added the tls label Apr 12, 2020
@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-key-update branch 2 times, most recently from 34700e0 to f657cb3 Compare April 13, 2020 19:29
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #2586 into master will decrease coverage by 0.14%.
The diff coverage is 50.52%.

@@            Coverage Diff             @@
##           master    #2586      +/-   ##
==========================================
- Coverage   88.47%   88.33%   -0.15%     
==========================================
  Files         246      246              
  Lines       52003    52132     +129     
==========================================
+ Hits        46010    46049      +39     
- Misses       5993     6083      +90     
Impacted Files Coverage Δ
scapy/layers/tls/record_tls13.py 83.33% <ø> (-2.93%) ⬇️
scapy/layers/tls/automaton_cli.py 79.43% <40.00%> (-3.25%) ⬇️
scapy/layers/tls/handshake.py 83.27% <43.66%> (-4.03%) ⬇️
scapy/layers/tls/automaton_srv.py 76.90% <65.95%> (-1.14%) ⬇️
scapy/layers/tls/automaton.py 85.36% <100.00%> (-0.59%) ⬇️
scapy/layers/tls/record.py 90.22% <100.00%> (-0.58%) ⬇️
scapy/layers/tls/session.py 78.40% <100.00%> (+0.16%) ⬆️
scapy/layers/tls/extensions.py 83.07% <0.00%> (+0.62%) ⬆️
... and 1 more

@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-key-update branch from f657cb3 to 126a1dc Compare April 13, 2020 21:29
@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-key-update branch from 126a1dc to dc2748c Compare April 17, 2020 19:28
@gpotter2 gpotter2 marked this pull request as ready for review April 17, 2020 21:39
@gpotter2 gpotter2 force-pushed the romain-perez-add-tls13-client-key-update branch from dc2748c to 7839ca9 Compare April 19, 2020 15:26
@gpotter2 gpotter2 requested a review from guedou April 26, 2020 14:26
@romain-perez romain-perez mentioned this pull request Apr 30, 2020
9 tasks
@gpotter2
Copy link
Member Author

gpotter2 commented May 2, 2020

@guedou @p-l- This is ready for review.

@guedou guedou merged commit 2233f73 into secdev:master May 3, 2020
@gpotter2 gpotter2 deleted the romain-perez-add-tls13-client-key-update branch May 3, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants