Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Use AWS identity provider with SECRETHUB_IDENTITY_PROVIDER=aws envvar #129

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Use AWS identity provider with SECRETHUB_IDENTITY_PROVIDER=aws envvar #129

merged 3 commits into from
Sep 6, 2019

Conversation

SimonBarendse
Copy link
Member

No description provided.

mackenbach
mackenbach reviewed Sep 6, 2019
View reviewed changes
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Makes everything a lot sweeter straight out of the box. Love it. I have two small questions. Have a look.

pkg/secrethub/client.go Outdated Show resolved Hide resolved
pkg/secrethub/client.go Show resolved Hide resolved
@SimonBarendse
Swap "" and "key" when matching the configured identity provider
1b6648d 
To make "" stand out more, as it might otherwise be overlooked.
mackenbach
mackenbach approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@mackenbach mackenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@SimonBarendse SimonBarendse merged commit 5268dc9 into develop Sep 6, 2019
@SimonBarendse SimonBarendse deleted the feature/use-aws branch September 6, 2019 13:54
@SimonBarendse SimonBarendse mentioned this pull request Sep 9, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mackenbach mackenbach mackenbach approved these changes

@jpcoenen jpcoenen Awaiting requested review from jpcoenen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBarendse @mackenbach