This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function to validate uuid strings
Use a value instead of pointer for created_by field of service, as services are always created by an account. This field is not optional.
These fields are always set.
…-optional Make created_by field of service non-optional
Make repo created_at and last_modified_at non-optional
This makes it easier to use the client directly in applications.
This is done to make clear more elaborate use is possible.
Add Read and ReadString convenience functions
DirFS was a legacy remnant that we renamed to the much simpler Tree.
Rename dirfs.go to tree.go
Add/improve godoc package comments
mackenbach
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
created_by
field of service non-optional (Make created_by field of service non-optional #131)created_at
andlast_modified_at
non-optional (Make repo created_at and last_modified_at non-optional #132)