Remove schema facility and most of formats #776
Conversation
|
Some windows runners seem to calculate test coverage differently than the rest and thus drop below the already lowered constraint. I'll fix this, when this PR is no longer blocked by other PRs. |
The usage of the securesystemslib schema/formats facility has been little by little phased out and is now nowhere used anymore. Several reasons to not use it are listed in secure-systems-lab#183. This patch removes schema.py along with all securesystemslib schema definitions in formats.py. Additionally, it removes unrelated and unused helper functions in formats.py. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
See 8df5fcd (75 was not enough). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
9be1638 further lowers the coverage requirement. As before, this does not mean that there are fewer tests (see commit message). |
Some of the bad coverage is quite expected (aws, azure, gcp, sigstore). I was surprised that HSMSigner is the worst though -- I wonder what that's about. |
securesystemslib/.github/workflows/_test.yml Lines 62 to 64 in 37089c5 |
blocks on #773, #774, #775 (commits are included in this PR)close #183
The usage of the securesystemslib schema/formats facility has been little by little phased out and is now nowhere used anymore. Several reasons to not use it are listed in #183.
This patch removes schema.py along with all securesystemslib schema definitions in formats.py.
Additionally, it removes unrelated and unused helper functions in formats.py.