Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the AI API key also from an environment variable #1181

Merged
merged 2 commits into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ gosec can suggest fixes based on AI recommendation. It will call an AI API to re

You can enable this feature by providing the following command line arguments:
- `ai-api-provider`: the name of the AI API provider, currently only `gemini`is supported.
- `ai-api-key`: the key to access the AI API, For gemini, you can create an API key following [these instructions](https://ai.google.dev/gemini-api/docs/api-key).
- `ai-api-key` or set the environment variable `GOSEC_AI_API_KEY`: the key to access the AI API,
For gemini, you can create an API key following [these instructions](https://ai.google.dev/gemini-api/docs/api-key).
- `ai-endpoint`: the endpoint of the AI provider, this is optional argument.


Expand Down
10 changes: 8 additions & 2 deletions cmd/gosec/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
$ gosec -exclude=G101 $GOPATH/src/github.com/example/project/...

`
// Environment variable for AI API key.
aiApiKeyEnv = "GOSEC_AI_API_KEY"

Check failure on line 63 in cmd/gosec/main.go

View workflow job for this annotation

GitHub Actions / test (1.21.12, latest)

G101: Potential hardcoded credentials (gosec)

Check failure on line 63 in cmd/gosec/main.go

View workflow job for this annotation

GitHub Actions / test (1.22.5, latest)

G101: Potential hardcoded credentials (gosec)
Fixed Show fixed Hide fixed
)

type arrayFlags []string
Expand Down Expand Up @@ -468,8 +470,12 @@
reportInfo := gosec.NewReportInfo(issues, metrics, errors).WithVersion(Version)

// Call AI request to solve the issues
if *flagAiApiProvider != "" && *flagAiApiKey != "" {
err := autofix.GenerateSolution(*flagAiApiProvider, *flagAiApiKey, *flagAiEndpoint, issues)
aiApiKey := os.Getenv(aiApiKeyEnv)
if aiApiKeyEnv == "" {
aiApiKey = *flagAiApiKey
}
if *flagAiApiProvider != "" && aiApiKey != "" {
err := autofix.GenerateSolution(*flagAiApiProvider, aiApiKey, *flagAiEndpoint, issues)
if err != nil {
logger.Print(err)
}
Expand Down
Loading