Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template/koa-rest-api: koa-bodyparser => @koa/bodyparser #1605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jul 2, 2024

#1603 (review)

Co-authored-by: Aaron Moat <amoat@seek.com.au>
@72636c 72636c requested a review from a team as a code owner July 2, 2024 03:54
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 163bb4c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c
Copy link
Member Author

72636c commented Jul 2, 2024

Do we want a patch for this?

@AaronMoat
Copy link
Contributor

I'd hold off on the patch until koajs/bodyparser#161 settles, personally

@samchungy
Copy link
Contributor

Should we renovate replace it?

@@ -33,8 +33,8 @@
},
"devDependencies": {
"@types/chance": "^1.1.3",
"@types/co-body": "^6.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 worth upstreaming?

@AaronMoat
Copy link
Contributor

🤔 I think @koa/bodyparser bundles with types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants