Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in AlterParitionReassignment client responses #119

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

pecigonzalo
Copy link
Contributor

This is basically a copy of the problem found in #103.

I suspect there could be other instances of the same pattern in other places.

Example error:

Response contains errors: map[0:[39] Invalid Replica Assignment: the replica assignment is invalid: Replica assignment has brokers that are not alive. Replica list:ArrayBuffer(0), live broker list: Set(1, 2, 3) 1:[39] Invalid Replica Assignment: the replica assignment is invalid: Replica assignment has brokers that are not alive. Replica list: ArrayBuffer(1, 2, 0), live broker list: Set(1, 2, 3) 2:[39] Invalid Replica Assignment: the replica assignment is invalid: Replica assignment has brokers that are not alive. Replica list: ArrayBuffer(2, 0, 1), live broker list: Set(1, 2, 3)]

TODO:

  • Add tests

@pecigonzalo pecigonzalo requested a review from a team as a code owner February 21, 2023 19:34
Copy link
Contributor

@hhahn-tw hhahn-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once more for your contribution!

@hhahn-tw hhahn-tw merged commit 342c7c3 into segmentio:master Feb 23, 2023
@pecigonzalo pecigonzalo deleted the fix/update-topic-errors branch February 24, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants