-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Earliest and Latest reset options #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment about renaming our public GetOffset function, but once that is fixed feel free to merge this. Nice work on this!
pkg/groups/groups.go
Outdated
@@ -192,3 +192,27 @@ func ResetOffsets( | |||
}, | |||
) | |||
} | |||
|
|||
// getOffset gets earliest/latest offset for a given topic partition for resetting offsets of consumer group | |||
func GetOffset( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename this function to make it more clear that this only works with earliest/latest? I am slightly worried open source users will depend on this and this may cause confusion/headaches in the future
No description provided.