Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: augment C with semgrep constructs #480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: augment C with semgrep constructs #480

wants to merge 3 commits into from

Conversation

brandonspark
Copy link
Contributor

@brandonspark brandonspark commented Apr 24, 2024 •
edited
Loading

This PR augments the C grammar with Semgrep constructs, so that we can move to deprecate the pfff parser for C.

I went through all the sgrep-exts in Parser_cpp.mly to make sure that we maintain parity.

Added some cpp stuff too.

Security

  • Change has no security implications (otherwise, ping the security team)

@brandonspark brandonspark requested a review from a team as a code owner April 24, 2024 19:51
@brandonspark brandonspark requested review from amchiclet and IagoAbal and removed request for a team April 24, 2024 19:51
aryx
aryx approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think medium-term we want to get rid of semgrep-c and just use semgrep-cpp to also parse C code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryx aryx aryx approved these changes

@amchiclet amchiclet Awaiting requested review from amchiclet amchiclet is a code owner automatically assigned from semgrep/pa

@IagoAbal IagoAbal Awaiting requested review from IagoAbal IagoAbal is a code owner automatically assigned from semgrep/pa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonspark @aryx