Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(move-on-aptos): v2 features #503

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Feat(move-on-aptos): v2 features #503

merged 2 commits into from
Aug 8, 2024

Conversation

ArArgon
Copy link
Contributor

@ArArgon ArArgon commented Aug 6, 2024 •
edited by nmote
Loading

  • Move on aptos v2 features:
    • Enum
    • Match pattern
    • Positional fields
    • Package visibility
    • Alternative syntax for struct and enum
  • Bug fixes
    • vector[...] is correctly parsed
    • Change return's precedence
    • Some grammar clean-ups

Security

  • Change has no security implications (otherwise, ping the security team)

@ArArgon ArArgon requested a review from a team as a code owner August 6, 2024 18:10
@ArArgon ArArgon requested review from amchiclet and nmote and removed request for a team August 6, 2024 18:10
nmote
nmote approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@nmote nmote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with move on aptos, but this looks reasonable and well-tested to me.

@nmote nmote merged commit b66e37e into semgrep:main Aug 8, 2024
2 checks passed
@nmote
Copy link
Collaborator

nmote commented Aug 8, 2024

I've updated https://github.com/semgrep/semgrep-move-on-aptos with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmote nmote nmote approved these changes

@amchiclet amchiclet Awaiting requested review from amchiclet amchiclet is a code owner automatically assigned from semgrep/pa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArArgon @nmote