Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"To" names with commas cause mail delivery to fail #352

Closed
haleyrc opened this issue Feb 22, 2019 · 1 comment · Fixed by #353
Closed

"To" names with commas cause mail delivery to fail #352

haleyrc opened this issue Feb 22, 2019 · 1 comment · Fixed by #353
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@haleyrc
Copy link
Contributor

haleyrc commented Feb 22, 2019

Issue Summary

Providing a name to mail.NewMail with a comma causes the email to be sent erroneously as the first "word" will be used as the email address.

Steps to Reproduce

  1. Create an email like mail.NewMail("My Company, LLC", "mycompany@example.com").
  2. Attempt to send the email.
  3. SendGrid activity feed shows a bounced email to my.

If NewMail automatically double-quoted names that are not already double-quoted, it would solve the issue for commas as well as any other characters outside of the normal range.

Technical details:

  • sendgrid-go Version: v3.4.2-0.20190124235127-1e8aa9067d63
  • Go Version: 1.11.5
@haleyrc haleyrc mentioned this issue Feb 22, 2019
Merged
7 tasks
@thinkingserious thinkingserious added type: bug bug in the library status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty labels Feb 26, 2019
@thinkingserious
Copy link
Contributor

Hello @haleyrc,

Thanks for taking the time to identify and fix the issue!

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: double quote escape names with special characters haleyrc/sendgrid-go
2 participants
@thinkingserious @haleyrc