fix: double quote escape names with special characters #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 22, 2019 15:58
In order to ensure compliance with the special characters clause in RFC5322, it is safest to enclose all to names in double quotes. The easiest place to do this is in NewEmail, but other tests need to be updated to expect double-quoted names as well.
Only names which are not already double-quoted are modified.
Names that don't require quoting, either because they are already quoted or because they don't contain any special characters shouldn't be modified.
thinkingserious
added
the
status: code review request
|
|
|
Failed checks seem to be related exclusively to invalid |
thinkingserious
added
status: work in progress
|
Hello @haleyrc, In order for us to merge/review this we need a signed CLA. If you add an email address to your GitHub profile and try again, all should be good. Thanks! With Best Regards, Elmer |
|
@thinkingserious I've signed the CLA so hopefully everything is good to go from here. |
|
Could use this, just ran into this quietly 200ing and just not sending the email. |
thinkingserious
changed the title
childish-sambino
pushed a commit
that referenced
this pull request
Sep 23, 2020
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed. Reverts #353
childish-sambino
pushed a commit
that referenced
this pull request
Sep 23, 2020
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed. Reverts #353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #352
Checklist
Short description of what this PR does:
mail.NewEmailwith double quotes to comply with RFC5322's section on special characters.If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.