Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mimetypes in the NewSingleEmail function #116

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

depado
Copy link
Contributor

@depado depado commented Jul 3, 2017

As of today the NewSingleEmail function doesn't use the right mimetypes which cause mail clients to interprete only the plaintext part of the sent mails. This PR fixes this.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 3, 2017
@SendGridDX
Copy link

SendGridDX commented Jul 3, 2017

CLA assistant check
All committers have signed the CLA.

@depado depado changed the title Fixing mimetypes Fixing mimetypes in the NewSingleEmail function Jul 3, 2017
@depado depado changed the title Fixing mimetypes in the NewSingleEmail function Fixing mimetypes in the NewSingleEmail function Jul 3, 2017
@thinkingserious
Copy link
Contributor

Hello @depado,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 412f14a into sendgrid:master Jul 4, 2017
@depado
Copy link
Contributor Author

depado commented Jul 4, 2017

All done ! 🎉
Thanks for accepting the PR and thanks for the awesome service ❤️

@depado depado deleted the fix_single_email branch July 4, 2017 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants