Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megacheck found 2 small issues #215

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Megacheck found 2 small issues #215

merged 2 commits into from
Oct 29, 2017

Conversation

vaskoz
Copy link
Contributor

@vaskoz vaskoz commented Oct 27, 2017

honnef.co/go/tools/cmd/megacheck found 2 small issues:

sendgrid_test.go:23:2: var testAPIKey is unused (U1000)
sendgrid_test.go:165:5: should omit comparison to bool constant, can be simplified to !strings.Contains(err.Error(), "Client.Timeout exceeded while awaiting headers") (S1002)

This PR removes the unused variable and simplifies the boolean condition.

@vaskoz vaskoz added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 27, 2017
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier merged commit e440661 into sendgrid:master Oct 29, 2017
@mbernier
Copy link
Contributor

Thanks @vaskoz!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants